feat(core): [Logs and Metrics Enable Flags 14] Warn for legacy Metrics configuration - #5955
Open
adinauer wants to merge 3 commits into
Open
feat(core): [Logs and Metrics Enable Flags 14] Warn for legacy Metrics configuration#5955adinauer wants to merge 3 commits into
adinauer wants to merge 3 commits into
Conversation
Emit tailored migration warnings for explicit metrics.enabled values while preserving manual Metrics capture regardless of the obsolete setting. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This was referenced Aug 13, 2026
📲 Install BuildsAndroid
|
8 tasks
Contributor
Performance metrics 🚀
|
This was referenced Aug 13, 2026
…y-metrics-external
This was referenced Aug 13, 2026
…y-metrics-external
8 tasks
adinauer
marked this pull request as ready for review
August 13, 2026 13:41
adinauer
requested review from
markushi,
romtsn and
runningcode
as code owners
August 13, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Logs and Metrics Enable Flags)
📜 Description
Continues parsing nullable
metrics.enabledexternal configuration and emits tailored migration warnings duringSentryOptions.mergefor explicittrueandfalsevalues.The obsolete value is not applied. Manual
Sentry.metrics()capture remains active for either value, while absent configuration emits no warning.💡 Motivation and Context
The aggregate Metrics enable flag has been removed. Keeping nullable external parsing temporarily lets users of
sentry.properties, environment variables, and system properties receive a targeted migration warning instead of having obsolete configuration silently ignored.💚 How did you test it?
./gradlew :sentry:test./gradlew spotlessApply apiDumptrue, and explicitfalseconfiguration📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Add equivalent migration warnings for the legacy Spring Boot Metrics property.
#skip-changelog